Okay
  Public Ticket #1367078
Setting a product as downloadable brakes the detail layout
Closed

Comments

  • MatteoBeretta started the conversation
    November 13, 2017 at 5:13pm

    I’ve tried to set a product of sample installation as downloadable, but some elements like quantity, add to cart and other button, are placed outside of "product-detail-infomation" div bun in a "product-add-form" div as you can see in the attachment.

    How can be fixed?

  • [deleted] replied
    November 14, 2017 at 4:13pm

    Hello,

    Thanks for your info, can you please provide your site info ( site url, admin account and ssh account ) I will check and help you

  • MatteoBeretta replied
    November 14, 2017 at 4:35pm

    I’m working on localhost at now. I’ve just installed the full demo of Claue on Magento 2.2, enabled the Popup gallery feature and added set the product with sku NEW_05 as downloadable product setting as no weight and adding a file as downloadable item.

  • [deleted] replied
    November 15, 2017 at 6:57am

    Hi,

    This is patch for downloadable product, please download and update for your theme

    Best regards!

  • MatteoBeretta replied
    November 15, 2017 at 8:55am

    Hi, thanks for the reply.

    I think I miss something, because patching, I get the correctly pricing and quantity style but the downloadable information and sample link isn’t rendered nowhere in the page.

  • [deleted] replied
    November 15, 2017 at 9:20am

    Hi,

    Sorry, please update again

    Best regards!

  • [deleted] replied
    November 15, 2017 at 9:51am

    Hi,

    Please run command deploy after update

    Best regards!

  • MatteoBeretta replied
    November 15, 2017 at 1:17pm

    OK, thanks, now it works.

    Will those files be included in next Claue releases or I have to keep them in a child theme to keep them after updates?

  • [deleted] replied
    November 15, 2017 at 1:38pm

    Hi, 

    Yes, the pacth will update on next theme version

    Best regards!

  • MatteoBeretta replied
    December 30, 2017 at 9:13am

    I’ve just reinstalled a fresh Magento 2.2 site with Claue and patch_theme_version_1.4.9 but the issue is still present, so I have to apply the patch of this ticket.

  • [deleted] replied
    January 2, 2018 at 2:24am

    Hi,

    Thanks for feedback. Sorry for the inconvenience, we will update the pacth on new theme version.

    Best regards!

  • MatteoBeretta replied
    January 3, 2018 at 11:10am

    Installing this patch on Magento 2.2.2 with Claue v1.4.9 I get the following error:

    1 exception(s):
    Exception #0 (Magento\Framework\Config\Dom\ValidationException): Element 'attribute': This element is not expected.
    Line: 1376
Element 'referenceBlock', attribute 'element': The attribute 'element' is not allowed.
    Line: 1400
Element 'referenceBlock': The attribute 'name' is required but missing.
    Line: 1400
Exception #0 (Magento\Framework\Config\Dom\ValidationException): Element 'attribute': This element is not expected.
    Line: 1376
Element 'referenceBlock', attribute 'element': The attribute 'element' is not allowed.
    Line: 1400
Element 'referenceBlock': The attribute 'name' is required but missing.
    Line: 1400
#0 MY-BASE-PATH/vendor/magento/framework/Config/Dom.php(115): Magento\Framework\Config\Dom->_initDom('<layout xmlns:x...')
    #1 MY-BASE-PATH/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php(111): Magento\Framework\Config\Dom->__construct('<layout xmlns:x...', Object(Magento\Framework\App\Arguments\ValidationState), Array, NULL, '/Applications/M...', '%message%\nLine:...')
    #2 MY-BASE-PATH/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php(66): Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject('Magento\\Framewo...', Array)
    #3 MY-BASE-PATH/vendor/magento/framework/ObjectManager/ObjectManager.php(56): Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create('Magento\\Framewo...', Array)
    #4 MY-BASE-PATH/vendor/magento/framework/Config/DomFactory.php(42): Magento\Framework\ObjectManager\ObjectManager->create('Magento\\Framewo...', Array)
    #5 MY-BASE-PATH/vendor/magento/framework/View/Model/Layout/Update/Validator.php(141): Magento\Framework\Config\DomFactory->createDom(Array)
    #6 MY-BASE-PATH/vendor/magento/framework/View/Model/Layout/Merge.php(461): Magento\Framework\View\Model\Layout\Update\Validator->isValid('<layout xmlns:x...', 'layout_merged', false)
    #7 MY-BASE-PATH/vendor/magento/framework/View/Model/Layout/Merge.php(442): Magento\Framework\View\Model\Layout\Merge->_validateMergedLayout('LAYOUT_frontend...', '<body>\n   <refe...')
    #8 MY-BASE-PATH/generated/code/Magento/Framework/View/Model/Layout/Merge/Interceptor.php(193): Magento\Framework\View\Model\Layout\Merge->load(Array)
    #9 MY-BASE-PATH/vendor/magento/framework/View/Layout/Builder.php(86): Magento\Framework\View\Model\Layout\Merge\Interceptor->load()
    #10 MY-BASE-PATH/vendor/magento/framework/View/Layout/Builder.php(63): Magento\Framework\View\Layout\Builder->loadLayoutUpdates()
    #11 MY-BASE-PATH/vendor/magento/framework/View/Layout.php(254): Magento\Framework\View\Layout\Builder->build()
    #12 MY-BASE-PATH/vendor/magento/framework/View/Layout.php(875): Magento\Framework\View\Layout->build()
    #13 MY-BASE-PATH/generated/code/Magento/Framework/View/Layout/Interceptor.php(414): Magento\Framework\View\Layout->getBlock('page_content_he...')
    #14 MY-BASE-PATH/vendor/magento/module-cms/Helper/Page.php(171): Magento\Framework\View\Layout\Interceptor->getBlock('page_content_he...')
    #15 MY-BASE-PATH/vendor/magento/module-cms/Controller/Noroute/Index.php(44): Magento\Cms\Helper\Page->prepareResultPage(Object(Magento\Cms\Controller\Noroute\Index\Interceptor), 'no-route')
    #16 MY-BASE-PATH/generated/code/Magento/Cms/Controller/Noroute/Index/Interceptor.php(24): Magento\Cms\Controller\Noroute\Index->execute()
    #17 MY-BASE-PATH/vendor/magento/framework/App/Action/Action.php(107): Magento\Cms\Controller\Noroute\Index\Interceptor->execute()
    #18 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
    #19 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Cms\Controller\Noroute\Index\Interceptor->___callParent('dispatch', Array)
    #20 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Cms\Controller\Noroute\Index\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
    #21 MY-BASE-PATH/generated/code/Magento/Cms/Controller/Noroute/Index/Interceptor.php(39): Magento\Cms\Controller\Noroute\Index\Interceptor->___callPlugins('dispatch', Array, Array)
    #22 MY-BASE-PATH/vendor/magento/framework/App/FrontController.php(55): Magento\Cms\Controller\Noroute\Index\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
    #23 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
    #24 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
    #25 MY-BASE-PATH/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(94): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
    #26 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(135): Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
    #27 MY-BASE-PATH/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(73): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
    #28 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(135): Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
    #29 MY-BASE-PATH/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
    #30 MY-BASE-PATH/generated/code/Magento/Framework/App/FrontController/Interceptor.php(26): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, NULL)
    #31 MY-BASE-PATH/vendor/magento/framework/App/Http.php(135): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
    #32 MY-BASE-PATH/generated/code/Magento/Framework/App/Http/Interceptor.php(24): Magento\Framework\App\Http->launch()
    #33 MY-BASE-PATH/vendor/magento/framework/App/Bootstrap.php(256): Magento\Framework\App\Http\Interceptor->launch()
    #34 MY-BASE-PATH/index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
    #35 {main}

    May be there is something to fix in /app/design/frontend/Mgs/claue_nmpv/Magento_Downloadable/layout/catalog_product_view_type_downloadable.xml file?

  • MatteoBeretta replied
    January 3, 2018 at 11:41am

    I’ve tried to change something to catalog_product_view_type_downloadable.xml file and is working but please check it, thanks.