Okay
  Public Ticket #2517863
Some general questions
Closed

Comments

  •  2
    bernieu2 started the conversation

    1. Are you aware of this console error and do you have plan to address? 

    "Fallback to JQueryUI Compat activated. Your store is missing a dependency for a jQueryUI widget. Identifying and addressing the dependency will drastically improve the performance of your site."


    2. Are you aware of these uncacheable blocks in your theme? With these blocks, the entire theme - every single page - is uncacheable. Cache miss. As a test, I changed these blocks to cacheable="true"  which allows pages to be cached. Cache hit. Obviously, that is not ideal... do you have plan to fix this? This is a major flaw in your theme that causes unnecessary load times...

    realbasi@s02ad app]$  grep -r cacheable * | grep xml | grep false
    code/MGS/GDPR/view/frontend/layout/gdpr_customer_index.xml:            <block class="MGSGDPRBlockCustomerButton" name="gdpr_customer_button" template="MGS_GDPR::customer/button.phtml" cacheable="false"/>

    code/MGS/GDPR/view/frontend/layout/customer_account_login.xml:            <block class="MagentoFrameworkViewElementTemplate" name="mgs_gdpr_login" after="-" cacheable="false" template="MGS_GDPR::customer/form/login.phtml" ifconfig="gdpr/general/active"/>

    code/MGS/GDPR/view/frontend/layout/customer_account_create.xml:            <block class="MagentoFrameworkViewElementTemplate" name="mgs_gdpr_login" after="-" cacheable="false" template="MGS_GDPR::customer/form/register.phtml" ifconfig="gdpr/general/active"/>

    code/MGS/Guestwishlist/view/frontend/layout/guestwishlist_index_index.xml:            <block class="MagentoFrameworkViewElementTemplate" name="guestwishlist.view" template="MGS_Guestwishlist::list.phtml" cacheable="false"/>

    design/frontend/Mgs/blank/Magento_Theme/layout/default.xml:                        <block class="MagentoFrameworkViewElementTemplate" name="mgs_gdpr_login_header" cacheable="false" template="MGS_GDPR::customer/form/login_header.phtml" ifconfig="gdpr/general/active"/>

    design/frontend/Mgs/blank/Magento_Theme/layout/default.xml:                <block class="MGSThemeSettingsBlockWishlistLink" name="wishlist-link-header" cacheable="false">

    design/frontend/Mgs/blank/Magento_Theme/layout/default.xml:                    <block class="MagentoWishlistBlockCustomerSidebar" name="wishlist_header" template="MGS_ThemeSettings::wishlist/list.phtml" cacheable="false"/>

    design/frontend/Mgs/supro/Magento_Captcha/layout/default.xml:            <block class="MagentoCaptchaBlockCaptcha" name="captcha-header" before="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.default.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.simple.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.bundle.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.grouped.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.configurable.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/supro/Magento_GiftMessage/layout/checkout_cart_item_renderers.xml:            <block class="MagentoGiftMessageBlockCartItemRendererActionsGiftOptions" name="checkout.cart.item.renderers.gift-card.actions.gift_options" template="cart/item/renderer/actions/gift_options.phtml" after="-" cacheable="false">

    design/frontend/Mgs/mgsmobile/Magento_Theme/layout/default.xml:                        <block class="MagentoFrameworkViewElementTemplate" name="mgs_gdpr_login_header" cacheable="false" template="MGS_GDPR::customer/form/login_header.phtml" ifconfig="gdpr/general/active"/>

    design/frontend/Mgs/mgsmobile/Magento_Theme/layout/default.xml:                <block class="MGSThemeSettingsBlockWishlistLink" name="wishlist-link-header" cacheable="false">

    design/frontend/Mgs/mgsmobile/Magento_Theme/layout/default.xml:                    <block class="MagentoWishlistBlockCustomerSidebar" name="wishlist_header" template="MGS_ThemeSettings::wishlist/list.phtml" cacheable="false"/>


  • [deleted] replied

    Hello,

    1) Yes we plan to upgrade this but it's not a simple task, so maybe it will be include in some next ugprade

    2) Please feel free to remove in theme code

    cacheable="false"

    we will check and remove it in next update