Okay
  Public Ticket #2922850
Poor Quality Coding Standard causing issues
Closed

Comments

  • Raheel started the conversation

    Hello ArrowHiTech

    We are using you Molla theme for Magento 2 in our website but while customization of the theme modules and design we came to know that the code quality is not as per Magento 2 coding standards. As we using CI pipe lining as per Magento rules for our repository on GitLab. Here are some examples paths:
    1. app/design/frontend/Mgs/eguanaMolla/Magento_Catalog/templates/product/list/items.phtml
    (In this template file you are directly calling object manager system configuration class a lot of time)
    2. app/code/MGS/Ajaxlayernavigation/Plugin/AjaxSearch.php
    (Using object manager in class directly)
    3. app/code/MGS/Mmegamenu/Controller/Adminhtml/Mmegamenu/Save.php
    (In this controller class you have implemented all the business logic, using deprecated functions and creating html code)

    There are many more and we can't list those all. Please let us know if there is any possible way to fix such kind of issues and improve code quality.

    Thank & Regards
    Raheel Shaukat

  • [deleted] replied

    Dear Raheel

    Thank you for your ticket

    Yes, we changed something in our coding way

    We are sorry for the inconvenience you get when trying to customize the theme. If you want to build content, we already make F-builder extension for you to do so, if you want to customize the functionalities, it's out of our support scope but we do provide outsource service, in case you're interested 

    Hope you can sympathize