After upgrading the theme with Magento 2.4.3 theme patch i got this error:

Magento Version: 2.4.4

On product page:

Exception #0 (Exception): Deprecated Functionality: Optional parameter $data declared before required parameter $registry is implicitly treated as a required parameter in app/code/MGS/Protabs/Block/DetailsProtabs.php on line 11

Hello,

IP address 118.70.184.26 has been added to the list of trusted hosts.

Please check now. 

Thanks.

Hi Hyun,

No the setup:upgrade command was successfully executed before. Its stuck on indexing so i should re-index first then let you know.

Is there anything other than this ?

Thanks

Hi Hyun,

All of the indexes are ready except "catalogsearch_fulltext" and that is due that Smile Elastic Module included in the theme and while indexing the "catalogsearch_fulltext" i got this error:

***************

Catalog Search index process error during indexation process:
Deprecated Functionality: trim(): Passing null to parameter #1 ($string) of type string is deprecated in /app/code/Smile/ElasticsuiteCatalog/Helper/AbstractAttribute.php on line 201

***************

Please look into this and all those error on the website.

Thank you.

So we can't fix these issues without downgrading the whole website? That's a lot of work to do again. 

Hi Hyun, 

Thanks a lot. 

So should i just merge this patch with the current theme?  Is there any extra steps involved? 

Thank You. 

Hi Hyun,

I applied the patch you sent me after that run the setup:upgrade successfully and then reindex all of the indexes without any errors.

Now its this single error on every page weather its homepage or product page or any category page:

********************

Exception #0 (Exception): Deprecated Functionality: Optional parameter $perrow declared before required parameter $nb_item is implicitly treated as a required parameter in /app/code/MGS/Mpanel/Helper/Data.php on line 997

********************

Thanks.

Hi Hyun, 

Thank you for this.

Please wait for sometime.. Category Product index may take 50-60 min to complete. 

Or should i run this from my end? 

Thanks. 

Hi Hyun, 

Indexes are ready and setup:upgrade as well but there are still errors.

ArgumentCountError: Too few arguments to function MGS\Mpanel\Helper\Data::getStoreConfig(), 1 passed in /home/printart/public_html/printartm2/app/code/MGS/Blog/Helper/Data.php on line 10 and exactly 2 expected in app/code/MGS/Mpanel/Helper/Data.php:184

Please check.

Thanks.

Hi Hyun,

Yes the homepage is working but there are still errors on category and product pages. And mini cart have some issues too.

Thanks.

Hi Hyun,

The site is working now and there is no fatal error on any page. Thanks for that. But, category pages missing the pagination. There is no pagination or infinite scroll loaded on any category.

Thanks.

Hi Hyun,

Yes i checked that error and that is due to usage of some deprecated event listeners used in the Theme. I traced this and found that somewhere in the theme these event listeners are used.

jQuery(window).load

Thanks.

Hi Hyun,

Thanks for that. But the infinity scroll still not working. Can you please look into this.

Thanks.

Thanks a lot Hyun. That was really great. There is just one more thing i can't see on product listing is Toolbar that contains listing view and sorting dropdown and a loader while infinite scrolling.

Thanks.

Hi Hyun, 

Please check the attachment. And loader is working now.

Thanks.

Hi Hyun,

Yes one of the dropdown was hidden but that was not the problem, I'm checking the changes by removing any custom styles applied, so it should have shown before.

And what thing causing this product per page error ? It should work with the ajax scroll.

Thanks.

Hi Hyun,

Okay got it, but I was thinking that this should set number of products to be loaded while ajax scrolling. Anyways thanks for the help. That's all I need for now. I will be in touch if any other problem shows up.

Thanks.

Hi Hyun,

I have fixed that 3rd party module error and successfully complied the code. Please check now and let me know if anything is to be done on my end.

Thanks.

Hi Hyun,

I reindexed the site again and still the product_color and artist attribute missing.

Thanks

Hi Hyun,

Are you going to look into this ? its really urgent.